Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(Fix) Alt format on group modules #3068

Merged
merged 1 commit into from
Mar 25, 2024
Merged

(Fix) Alt format on group modules #3068

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion src/bar.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -449,7 +449,17 @@
Json::Value& modules = config[module_list_name];
for (const Json::Value& module_name : modules) {
if (module_name.isString()) {
setupAltFormatKeyForModule(module_name.asString());
auto ref = module_name.asString();
if (ref.compare(0, 6, "group/") == 0 && ref.size() > 6) {
Json::Value& group_modules = config[ref]["modules"];

Check warning on line 454 in src/bar.cpp

View workflow job for this annotation

GitHub Actions / build

src/bar.cpp:454:24 [readability-identifier-naming] 

invalid case style for variable 'group_modules'
for (const Json::Value& module_name : group_modules) {

Check warning on line 455 in src/bar.cpp

View workflow job for this annotation

GitHub Actions / build

src/bar.cpp:455:35 [readability-identifier-naming] 

invalid case style for variable 'module_name'
if (module_name.isString()) {
setupAltFormatKeyForModule(module_name.asString());
}
}
} else {
setupAltFormatKeyForModule(ref);
}
}
}
}
Expand Down
Loading