-
Notifications
You must be signed in to change notification settings - Fork 161
[all-the-icons] Update to all-the-icons 6.0 (SVG) #1037
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
So on the one hand I've got this PR that has the potential to let me outsource all my icon needs and save hundreds of lines of some of the more complicated code I've written. On the other hand I've got issues of people who have all sorts of troubles with the few svg icons that I have introduced myself. Why can't thing things ever be simple? Anyway, thanks for the PR 👍. Please let me know when v6 is out. |
63bbd41
to
baf1390
Compare
While I think this would be a good a addition for the package I wonder, with this added, will it still be possible to not have any icons at all like I do now? |
It's not an addition, it's updating the already pre-existing theme to use the newest all-the-icons api, so I'm not sure how exactly this would affect your icon-less config. If it does then the easiest way to get rid of icons is by creating your own theme that defines nothing except the bare basics like fallbacks. |
@Alexander-Miller Thanks for your reply! Could you also please look at my issue regarding Treelib and extensions please? |
cf1130d
to
bd01fa2
Compare
Just saw this! Thanks for making this PR. FYI, the SVG branch is still in progress. There are a few issues that I aim to fix but haven't had the time. Hopefully this coming holiday will give me some time! |
This issue has been automatically marked as stale because it has not had recent activity (this bot only works as a reminder, it will not close issues). |
This issue has been automatically marked as stale because it has not had recent activity (this bot only works as a reminder, it will not close issues). |
eb2c0a4
to
0ddb664
Compare
3f44751
to
031caae
Compare
This issue has been automatically marked as stale because it has not had recent activity (this bot only works as a reminder, it will not close issues). |
031caae
to
cd690fc
Compare
This issue has been automatically marked as stale because it has not had recent activity (this bot only works as a reminder, it will not close issues). |
cd690fc
to
3d2df4b
Compare
3d2df4b
to
f0e9bac
Compare
f0e9bac
to
cf9e6fe
Compare
Migrated all-the-icons support from 5.x to the upcoming 6.0 (SVG) release.
Example setup for testing (needs all-the-icons 6.0 from git):
Pull request marked as draft for now, since all-the-icons 6 has not been released yet.