Skip to content

Commit

Permalink
pythongh-104146: Argument clinic: Remove dead code flagged by mypy's …
Browse files Browse the repository at this point in the history
…`truthy-bool` check
  • Loading branch information
AlexWaygood committed Aug 4, 2023
1 parent 2ba7c7f commit 0ad381c
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 7 deletions.
8 changes: 2 additions & 6 deletions Tools/clinic/clinic.py
Original file line number Diff line number Diff line change
Expand Up @@ -884,9 +884,7 @@ def output_templates(
converters = [p.converter for p in parameters]

has_option_groups = parameters and (parameters[0].group or parameters[-1].group)
default_return_converter = (not f.return_converter or
f.return_converter.type == 'PyObject *')

default_return_converter = f.return_converter.type == 'PyObject *'
new_or_init = f.kind.new_or_init

vararg: int | str = NO_VARARG
Expand Down Expand Up @@ -4422,7 +4420,7 @@ class DSLParser:
keyword_only: bool
positional_only: bool
group: int
parameter_state: int
parameter_state: ParamState
seen_positional_with_default: bool
indent: IndentStack
kind: FunctionKind
Expand Down Expand Up @@ -4776,8 +4774,6 @@ def state_modulename_name(self, line: str) -> None:
if not return_converter:
return_converter = CReturnConverter()

if not module:
fail("Undefined module used in declaration of " + repr(full_name.strip()) + ".")
self.function = Function(name=function_name, full_name=full_name, module=module, cls=cls, c_basename=c_basename,
return_converter=return_converter, kind=self.kind, coexist=self.coexist)
self.block.signatures.append(self.function)
Expand Down
2 changes: 1 addition & 1 deletion Tools/clinic/mypy.ini
Original file line number Diff line number Diff line change
Expand Up @@ -8,5 +8,5 @@ python_version = 3.10
# and be strict!
strict = True
strict_concatenate = True
enable_error_code = ignore-without-code,redundant-expr
enable_error_code = ignore-without-code,redundant-expr,truthy-bool
warn_unreachable = True

0 comments on commit 0ad381c

Please sign in to comment.