Quality of life improvements #30
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of this Pull Request the following has been completed:
Updated Storybook to the latest stable version
Switched out any storybook plugins to suitable alternatives, some plugins weren't compatible with storybook v8 and luckily it was easy enough to switch out affected areas.
Created a ReadMore component to hide/show blocks of text, currently only used on the Person Biography field. There is one limitation currently which is if you purposefully change the device width after the component is initialized then it won't reset the previous height of the content as when you shrink a devices width the content becomes longer.
Addressed any accessibility violations which were easy to fix, I've left the colour contract one as that will need addressing separately as a full colour pallet will needed instead of the three current colours.
Fixed some issues with the existing Layout components
Updated the Person CreditsTable design so it's easier to understand.