Skip to content

Update Niconama support #205

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
AlexAplin wants to merge 14 commits into
base: master
Choose a base branch
from
Draft

Update Niconama support #205

AlexAplin wants to merge 14 commits into from

Conversation

@AlexAplin
Copy link
Owner

@AlexAplin AlexAplin commented Apr 22, 2025 •
edited
Loading

Resolves #11. This also fixes get_media_from_manifest to actually respect the media type.

  • -c is not supported
  • On-air namas still don't work and might be troublesome to support. We'll likely need to pass cookies through on players down to ffmpeg -headers. This adds a warning to follow that work in On-air Niconama stream links #203
  • Better warnings when -an/-aq or -vn/-vq are specified together

@AlexAplin AlexAplin mentioned this pull request Apr 22, 2025
Open
@AlexAplin AlexAplin changed the title Add basic timeshift download support (WIP) Add basic timeshift download support Apr 23, 2025
@AlexAplin AlexAplin changed the title Add basic timeshift download support Update Niconama support Apr 23, 2025
fireattack
fireattack reviewed Apr 23, 2025
View reviewed changes
nndownload/nndownload.py Outdated
"type": "startWatching",
"data": {
"stream": {
"quality": "super_high",
Copy link
Contributor

@fireattack fireattack Apr 23, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs to be replaced by the highest quality that is acquired from params (params['program']['stream']['maxQuality']) because super_high is no longer the best quality for years (we have 6m and 12m now).

Copy link
Owner Author

@AlexAplin AlexAplin Apr 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is 12Mbps exclusive to some type of user/broadcast type? I tried setting up a broadcast now on premium and it seems the max is 6.

Copy link
Contributor

@fireattack fireattack Apr 23, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably only the "official" ones can do. I can't find a 12M rn but here is a 8M one: https://live.nicovideo.jp/watch/lv347308094

Also note that the actual bitrate is often much lower.

@fireattack
Copy link
Contributor

fireattack commented Apr 23, 2025 •
edited
Loading

I can help writing the comment downloading function once you're done. I have a working one myself.

Do note the proto schema data is directly copied from https://github.com/tsukumijima/NDGRClient (MIT) which was imported from https://github.com/n-air-app/nicolive-comment-protobuf (also MIT); I don't dump them myself.

@AlexAplin AlexAplin mentioned this pull request Jul 16, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@fireattack fireattack fireattack left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

enhancement site change

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Download timeshifted Niconama

3 participants

@AlexAplin @fireattack