Cherry-pick: Improved VFDO stream handling from AdvancedSharpAdbClient branch #268
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR cherry-picks commit
d5d4f7e68512618ece8cd3374a66b999ae16dbdafrom theAdvancedSharpAdbClientbranch, which introduces significant improvements to Virtual File Data Object (VFDO) stream handling.Changes Overview
The main improvement is that FileContents IStream is now created directly from temporary files, eliminating the need for intermediate stream copying and improving performance for drag-and-drop operations.
Key Technical Changes
Before: Stream contents were handled through
Action<Stream>delegates that would read from files and write to provided streams using buffer copying:After: Stream contents use a new delegate that returns
IStreamdirectly from files:Files Modified
StreamContentsproperty to newStreamdelegate typeStreamContentsdelegate definition and updated property typesCreateStreamOnFilemethod usingSHCreateStreamOnFileExBenefits
Original Commit Details
This cherry-pick brings these improvements to the master branch while preserving the original commit authorship and timestamp.
This pull request was created as a result of the following prompt from Copilot chat.
💬 Share your feedback on Copilot coding agent for the chance to win a $200 gift card! Click here to start the survey.