Add ConcurrencyExtras package#4
Open
erkekin wants to merge 1 commit into
Open
Conversation
erkekin
commented
Mar 7, 2026
erkekin
left a comment
erkekin
left a comment
Author
There was a problem hiding this comment.
hey @Alex-Ozun, I wanted to run tests but had compilation error. looks like you didn't include pointfree's lib.
| switch action { | ||
| case .enqueue: | ||
| await task.enqueue() | ||
| task.enqueue() |
Author
There was a problem hiding this comment.
this is an unrelated warning fix
There was a problem hiding this comment.
Pull request overview
This PR updates the Swift package configuration and tests to use Point-Free’s swift-concurrency-extras (specifically LockIsolated) and fixes a Swift concurrency compilation issue in EffectTest.expectTask.
Changes:
- Add
swift-concurrency-extrasas a package dependency and linkConcurrencyExtrasto theEffectTeststarget. - Update
RunInParallelUntilBothCompleteOrEitherThrowsTeststo useConcurrencyExtras.LockIsolated. - Remove an invalid
awaiton the synchronousTaskEffect.enqueue()call inEffectTest.expectTask.
Reviewed changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| Tests/EffectTests/RunInParallelUntilBothCompleteOrEitherThrowsTests.swift | Switches state isolation to ConcurrencyExtras.LockIsolated to resolve test compilation issues. |
| Sources/Effect/Effect.swift | Removes await from task.enqueue() (method is synchronous) to fix compilation under strict async/await rules. |
| Package.swift | Adds swift-concurrency-extras dependency and wires ConcurrencyExtras into EffectTests. |
| Package.resolved | Locks the new dependency (swift-concurrency-extras) in the resolved package set. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds the ConcurrencyExtras package to resolve test compilation issues.