feat: add StudioOTLPSpanExporter #358
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
this should be merged only after see: https://matter.aleph-alpha.de/aleph-alpha/pl/o6pwapzbn7fwfctk1rgo8dug4y |
moldhouse
force-pushed
the
studio-otel-tracing-2
branch
2 times, most recently
from
aacf044 to
c3570f9
Compare
- Introduced StudioOTLPSpanExporter for exporting traces to Pharia Studio via OTLP. - Updated __init__.py to include StudioOTLPSpanExporter in the module exports. - Removed unused SimpleSpanProcessor from StudioExporter. - Added StudioSpanProcessor to handle span processing. - Enhanced DevCsi class with methods to configure OTLP exporting.
…xporter integration - Removed the unused StudioOTLPSpanProcessor class from otlp_exporter.py. - Updated DevCsi to only check for StudioSpanProcessor when setting span exporters. - Enhanced existing_exporter method to return both StudioExporter and StudioOTLPSpanExporter types. - Added comprehensive tests for StudioOTLPSpanExporter, including initialization and configuration validation. - Introduced simple integration tests for OTLP exporter setup and functionality.
- Removed unused imports from otlp_exporter.py and tracing_test.py to streamline the codebase. - This cleanup enhances readability and maintains focus on relevant dependencies.
most of their testing surface is covered by the one e2e test, and they felt a bit too granular
testing the export and the tracing should be enough
since the trace export format is an implementation detail of our stack, we do not need to offer both options to the user
moldhouse
force-pushed
the
studio-otel-tracing-2
branch
from
d4d0127 to
6bffab7
Compare
moldhouse
force-pushed
the
studio-otel-tracing-2
branch
from
14cd936 to
2584696
Compare
moldhouse
force-pushed
the
studio-otel-tracing-2
branch
from
2584696 to
c8e456a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.