Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Commands): MacOS copy command not working (#12) #13

Merged
merged 1 commit into from
Jun 6, 2024

Conversation

debling
Copy link
Contributor

@debling debling commented Jun 6, 2024

Description

Removed the unnecessary quote around the argument that is causing a syntax error when running osascript. Those quotes aren't needed since vim.system() will not word split the string.

Fixes #12

Type of change

  • Bug fix (non-breaking change which fixes an issue)

AlejandroSuero
AlejandroSuero previously approved these changes Jun 6, 2024
@AlejandroSuero
Copy link
Owner

@debling nice PR.

If you can make the changes according to the workflows' actions failing, I'll merge them ASAP.

Checks failing:

  • commitlint: The commit body is too long (max 100 chars per line). This doesn't need to change, but for future changes.
  • stylua: not happy with the quote escaping, make format should fix it, make lint to check afterwards.

Removed the unnecessary quote around the argument that is causing a
syntax error when running `osascript`. Those quotes aren't needed since
vim.system() will not word split the string.
@debling
Copy link
Contributor Author

debling commented Jun 6, 2024

Hi @AlejandroSuero ,

I fixed the checks that were failing:

  • commitlint: reworded commit so it doesn't fall into the sentence-case rule
  • stylelua: used make format lint to reformat and check the code.

Thank you for your feedback

@AlejandroSuero AlejandroSuero merged commit 6a7fb47 into AlejandroSuero:main Jun 6, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Copying screenshot to clipboard fails on MacOS
2 participants