This repository has been archived by the owner on Apr 19, 2024. It is now read-only.
[#89] replaced local imports with references to gopkg.in #91
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlecAivazis
force-pushed
the
fix/semantic-imports
branch
from
5cbf294 to
6120186
Compare
|
@coryb i'm going to merge this since it's been open for a week now - if you see anything we can change it afterwards |
|
Sorry, you have a knack for catching me on vacation, so I missed the original request. LGTM |
siredmar
pushed a commit
to siredmar/survey
that referenced
this pull request
Feb 20, 2020
…lecAivazis#91) * [AlecAivazis#89] replaced local imports with references to gopkg.in * fixed files variable in task file * added go import path to travis config
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug reported in #89 where internal imports were still using
github.com/alecaivazis/surveywhich made changing things insurvey/corefeel clunky since they had to be changed inalecaivazis/survey.