-
-
Notifications
You must be signed in to change notification settings - Fork 5
Add secondary user locale (region) to string lookup #18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Thanks for contributing this. Sorry for the inconvenience, I think I may have fixed this same issue (or at least the same symptoms) on master in #8 but not released it yet while I was waiting for feedback from the original reporter. But since multiple people are encountering this issue I think it's time to cut a new release.
|
The HEAD build does not work for me:
These are my language settings: Also note that my OS was originally installed as de-DE but I installed the en-US language pack afterwards. It could be that some UIs in Windows are not localized properly, this is the case for my logon screen (everything is en-US except for the "Other User" option and the "Forgot my PIN" link text, these still appear in de-DE..). |
Thanks for these updates, it looks like AuthenticatorChooser guessed that the User locale was en-US based on |
Unfortunately I cannot tell if the credential dialog is incorrectly using the "format"/"location" locale for UI strings, or if this is because the system was originally installed as |
Thanks. That's probably the issue I was having. Every time I look up the difference between those properties, I think I'm using the right one, and then it turns out I got it backwards. |
I was going to suggest looking at those "Welcome screen and new user accounts settings" because that's what fixed it when I was trying to test with different languages in the dialog, but since you already tried that, I'm not sure why you're still seeing multiple languages in the dialog. I assume you rebooted after making all those changes? |
Yes, I rebooted after changing my locale settings. |
When that Windows Security dialog box appears, here are all the relevant-looking registry keys or values I observed
You mentioned you already looked at some of these. Maybe one of these contains the reason you're still seeing de-DE strings in the dialog box even after setting all the locale values to en-US for your user and machine? |
Here are the registry values as configured on my system using en-US for everything except de-DE for "Format"/"Location":
MachinePreferredUILanguages=en-US
de-DE=en-US en-US=de-DE
en-US
en-US de-DE
1033 (en-US)
empty
empty |
…-preferred locale. This is necessary because installing a language pack doesn't always install all MUI files, which leads to Windows falling back to strings from the original OS installation language.
Thank you again for this contribution. I was able to reproduce the same or similar symptom on a VM. In that case, the problem was missing en-US MUI files after installing the English language pack, so Windows was falling back to the de-DE MUI files from when the OS was first installed. I was able to get it working by checking for strings in all installed languages, not just the most preferred one for the user and the system. Feel free to try build 29 for commit b4db9ded13e4a8133247cf2146ea708390403c8d and see if that works on your machine too. |
On my system (24H2) I have a combination of en-US and de-DE locales. I use en-US as UI locale, but de-DE is configured as a "region" for date/time formatting etc. Some dialogs (including the credential dialog) seem to choose their language based on the incorrect locale (de-DE). AuthenticatorChooser would choose the wrong strings in this case (en-US) and not do anything in the dialog.
This PR changes string lookup so that strings for the secondary locale are also looked up.
For the record, this is what the dialog looks like for me: