Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated Readme, detailed install instructions. #72

Merged
merged 6 commits into from
Oct 17, 2011

Conversation

masche842
Copy link
Contributor

perhaps a bit more detailed?

else
return languages.join(options[:spacer]).html_safe
end
raw(languages.join)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are missing the options[:spacer] here

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hehe looking in here at the same time and commenting ;-)
I will write specs for this as soon as possible - we really need that now!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, you're right, just a typo. I think the if is not needed, since join(nil) or join("") does exactly what you want, so you can just put options[:spacer] in.
Will add it in another pull request.

@tvdeyen
Copy link
Member

tvdeyen commented Oct 16, 2011

Thanks.

Could you please remove and ignore this .idea folder? Thanks.

@masche842
Copy link
Contributor Author

Yeah, sorry for messing around with the .idea... Sometimes git can be quite confusing. Tried to correct the commit with --amend... Whatever. I anyhow wanted only the first commit to be pulled, the page_helper was just a workaround for me.
Perhaps it's best to open a new pull request (a clean one this time...).

@masche842
Copy link
Contributor Author

Should be ok now.
I also wrote some spec sceleton, but without further knowledge about Pages I can't fill it properly.

@masche842 masche842 closed this Oct 17, 2011
@masche842 masche842 reopened this Oct 17, 2011
@tvdeyen
Copy link
Member

tvdeyen commented Oct 17, 2011

Yeah Git is hard to understand sometimes. Try Tower if you still are on a Mac. Its costs some Euros but is worth the money.

It is best that Robin and I writing the specs and tests. We began with it. ;)

@robinboening
Copy link
Contributor

we should move our conversations out to our google group.
we should generate traffic there :-)

Nethosting4You - Professional Hosting Solutions
Jacobs& Böning GbR
Cremon 33
20457 Hamburg

Tel: +49 (0)40 673 01 222
Fax: +49 (0)40 673 01 223

E-Mail: Info@Nethosting4You.de
Web: http://www.Nethosting4You.de

Am 17.10.2011 um 08:49 schrieb Thomas von Deyen:

Yeah Git is hard to understand sometimes. Try Tower if you still are on a Mac. Its costs some Euros but is worth the money.

It is best that Robin and I writing the specs and tests. We began with it. ;)

Reply to this email directly or view it on GitHub:
#72 (comment)

tvdeyen added a commit that referenced this pull request Oct 17, 2011
Updated Readme (detailed install instructions) and fixes for language_select helper
@tvdeyen tvdeyen merged commit 60e6f79 into AlchemyCMS:next_stable Oct 17, 2011
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants