-
-
Notifications
You must be signed in to change notification settings - Fork 315
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
updated Readme, detailed install instructions. #72
Conversation
else | ||
return languages.join(options[:spacer]).html_safe | ||
end | ||
raw(languages.join) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You are missing the options[:spacer]
here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hehe looking in here at the same time and commenting ;-)
I will write specs for this as soon as possible - we really need that now!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, you're right, just a typo. I think the if is not needed, since join(nil) or join("") does exactly what you want, so you can just put options[:spacer] in.
Will add it in another pull request.
Thanks. Could you please remove and ignore this |
Yeah, sorry for messing around with the .idea... Sometimes git can be quite confusing. Tried to correct the commit with --amend... Whatever. I anyhow wanted only the first commit to be pulled, the page_helper was just a workaround for me. |
Should be ok now. |
Yeah Git is hard to understand sometimes. Try Tower if you still are on a Mac. Its costs some Euros but is worth the money. It is best that Robin and I writing the specs and tests. We began with it. ;) |
we should move our conversations out to our google group. Nethosting4You - Professional Hosting Solutions Tel: +49 (0)40 673 01 222 E-Mail: Info@Nethosting4You.de Am 17.10.2011 um 08:49 schrieb Thomas von Deyen:
|
Updated Readme (detailed install instructions) and fixes for language_select helper
perhaps a bit more detailed?