Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix filtering associated models by id #3067

Merged
merged 1 commit into from
Oct 14, 2024
Merged

Fix filtering associated models by id #3067

merged 1 commit into from
Oct 14, 2024

Conversation

tvdeyen
Copy link
Member

@tvdeyen tvdeyen commented Oct 14, 2024

What is this pull request for?

IDs are Strings in Rails params.

Checklist

  • I have followed Pull Request guidelines
  • I have added a detailed description into each commit message
  • I have added tests to cover this change

IDs are Strings in Rails params.
@tvdeyen tvdeyen added backport-to-7.2-stable Needs to be backported to 7.2-stable backport-to-7.3-stable Needs to be backported to 7.3-stable labels Oct 14, 2024
@tvdeyen tvdeyen requested a review from a team as a code owner October 14, 2024 13:29
Copy link

codecov bot commented Oct 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.59%. Comparing base (d5a5059) to head (2fbee96).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3067   +/-   ##
=======================================
  Coverage   96.59%   96.59%           
=======================================
  Files         236      236           
  Lines        6337     6337           
=======================================
  Hits         6121     6121           
  Misses        216      216           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tvdeyen tvdeyen merged commit 2caa660 into main Oct 14, 2024
41 checks passed
@tvdeyen tvdeyen deleted the fix-resource-filter branch October 14, 2024 13:38
@alchemycms-bot
Copy link
Collaborator

💔 Some backports could not be created

Status Branch Result
7.2-stable Backport failed because of merge conflicts
7.3-stable

Manual backport

To create the backport manually run:

backport --pr 3067

Questions ?

Please refer to the Backport tool documentation and see the Github Action logs for details

@tvdeyen
Copy link
Member Author

tvdeyen commented Oct 14, 2024

💚 All backports created successfully

Status Branch Result
7.2-stable

Questions ?

Please refer to the Backport tool documentation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-to-7.2-stable Needs to be backported to 7.2-stable backport-to-7.3-stable Needs to be backported to 7.3-stable
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants