Use Handlebars templates from npm #3044
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3044 +/- ##
==========================================
- Coverage 96.63% 96.63% -0.01%
==========================================
Files 236 236
Lines 6333 6332 -1
==========================================
- Hits 6120 6119 -1
Misses 213 213 ☔ View full report in Codecov by Sentry. |
Instead of the very outdated Ruby gem we use the currentl npm package. Providing the same precompilation like before.
tvdeyen
force-pushed
the
handlebars-npm
branch
from
6ac4718
to
cda0815
Compare
sascha-karnatz
approved these changes
Sep 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this pull request for?
Instead of the very outdated Ruby gem we use
the currentl npm package. Providing the same
precompilation like before.
Checklist