Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use time.formats.alchemy.default for datetime view #3001

Merged
merged 1 commit into from
Aug 28, 2024

Conversation

tvdeyen
Copy link
Member

@tvdeyen tvdeyen commented Aug 27, 2024

What is this pull request for?

Using nil as default format for I18n can lead to
unpredictable results. We have a default alchemy
time format, let's use that as default format for
ingredient datetime view.

Checklist

  • I have followed Pull Request guidelines
  • I have added a detailed description into each commit message
  • I have added tests to cover this change

@tvdeyen tvdeyen requested a review from a team as a code owner August 27, 2024 20:52
@tvdeyen tvdeyen added this to the 7.3 milestone Aug 27, 2024
Copy link

codecov bot commented Aug 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.48%. Comparing base (b14d0bc) to head (52e804c).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3001   +/-   ##
=======================================
  Coverage   96.48%   96.48%           
=======================================
  Files         233      233           
  Lines        6308     6308           
=======================================
  Hits         6086     6086           
  Misses        222      222           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Using nil as default format for I18n can lead to
unpredictable results. We have a default alchemy
time format, let's use that as default format for
ingredient datetime view.
@tvdeyen tvdeyen force-pushed the change-default-datetime-format branch from 42101a7 to 52e804c Compare August 28, 2024 09:47
@tvdeyen tvdeyen enabled auto-merge August 28, 2024 09:48
@tvdeyen tvdeyen merged commit 8d88024 into AlchemyCMS:main Aug 28, 2024
35 checks passed
@tvdeyen tvdeyen deleted the change-default-datetime-format branch August 28, 2024 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants