Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow Rails 7.2 #2999

Merged
merged 10 commits into from
Sep 3, 2024
Merged

Allow Rails 7.2 #2999

merged 10 commits into from
Sep 3, 2024

Conversation

tvdeyen
Copy link
Member

@tvdeyen tvdeyen commented Aug 27, 2024 •
edited by sascha-karnatz
Loading

What is this pull request for?

  • Adds Rails 7.2 support
  • Removes support for Ruby 3.0. Rails 7.2 bumped the version and Ruby 3.0 is not supported anymore anyway.

Needs

Checklist

  • I have followed Pull Request guidelines
  • I have added a detailed description into each commit message
  • I have added tests to cover this change

@tvdeyen tvdeyen mentioned this pull request Aug 27, 2024
Closed
4 tasks
@tvdeyen tvdeyen force-pushed the rails-7.2 branch 4 times, most recently from 2a3b709 to a5653c4 Compare August 29, 2024 09:02
@codecov Codecov
Copy link

codecov bot commented Aug 29, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.47%. Comparing base (86cdac7) to head (2eb0f9c).
Report is 15 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #2999   +/-   ##
=======================================
  Coverage   96.46%   96.47%           
=======================================
  Files         237      237           
  Lines        6393     6403   +10     
=======================================
+ Hits         6167     6177   +10     
  Misses        226      226

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tvdeyen tvdeyen force-pushed the rails-7.2 branch 2 times, most recently from 2b6c0d3 to 3e27c9f Compare August 29, 2024 15:10
@tvdeyen tvdeyen marked this pull request as ready for review September 3, 2024 06:17
@tvdeyen tvdeyen requested a review from a team as a code owner September 3, 2024 06:17
@tvdeyen tvdeyen added this to the 7.3 milestone Sep 3, 2024
@tvdeyen
CI: Build for Rails 7.2
a65424d 
and drop builds for Ruby 3.0
@tvdeyen
Use at least awesome_nested_set 3.7.0
fb3bc05 
Adds support for Rails 7.2
@tvdeyen
Use rspec-rails 6.1
f85eb54 
This is the version for Rails >= 6.1
@tvdeyen
Set minimum Ruby version to 3.1
9122ddb 
Rails 7.2 needs Ruby 3.1 as minimum. It is out of support anyway.
@tvdeyen
Add csv to gemspec
99a1af9 
Get rid of warning about csv not being part of standard
gems from Ruby 3.4 onwards.
@tvdeyen
Use positional arguments to define enum
eee8603
@tvdeyen
Autoformat dummy app event.rb
9d63ec7
@tvdeyen
Fix warning about already defined constant in resource table specs
bfa7a61
sascha-karnatz
sascha-karnatz approved these changes Sep 3, 2024
View reviewed changes
Copy link
Contributor

@sascha-karnatz sascha-karnatz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. A few feature specs are failing at the moment.

@tvdeyen
Fix setting action_dispatch.show_exceptions for Rails 7.2
2eb0f9c 
Since Rails 7.1 we need to set this to `:none`.
The fix made was not very future proof...
@tvdeyen tvdeyen merged commit 35a64e5 into main Sep 3, 2024
41 checks passed
@tvdeyen tvdeyen deleted the rails-7.2 branch September 3, 2024 11:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sascha-karnatz sascha-karnatz sascha-karnatz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
7.3
Development

Successfully merging this pull request may close these issues.
2 participants
@tvdeyen @sascha-karnatz