Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[7.2-stable] fix PictureEditor defaultCropSize #2992

Merged
merged 1 commit into from
Aug 10, 2024

Conversation

alchemycms-bot
Copy link
Collaborator

Backport

This will backport the following commits from main to 7.2-stable:

Questions ?

Please refer to the Backport tool documentation

Since ae15cdc we use our
own max function and not the Underscore.js one. This function
does not take an array, nut just two arguments.

(cherry picked from commit 9a181a1)
Copy link

codecov bot commented Aug 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.99%. Comparing base (1e1ee41) to head (b20db29).
Report is 1 commits behind head on 7.2-stable.

Additional details and impacted files
@@             Coverage Diff             @@
##           7.2-stable    #2992   +/-   ##
===========================================
  Coverage       95.99%   95.99%           
===========================================
  Files             233      233           
  Lines            6315     6315           
===========================================
  Hits             6062     6062           
  Misses            253      253           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tvdeyen tvdeyen merged commit a83c45b into 7.2-stable Aug 10, 2024
33 checks passed
@tvdeyen tvdeyen deleted the backport/7.2-stable/pr-2987 branch August 10, 2024 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants