Split dashboard into partials #2948
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The dashboard has now partials for each part (top, left column, right column) and widgets for the content placed into them. It looks the same as before, but can now be changed in the host app or extensions by overwriting on of the partials.
sascha-karnatz
approved these changes
Jun 27, 2024
|
Looks good! In the long run we can consider ViewComponents for the Widgets. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2948 +/- ##
=======================================
Coverage 95.96% 95.96%
=======================================
Files 232 232
Lines 6271 6271
=======================================
Hits 6018 6018
Misses 253 253 ☔ View full report in Codecov by Sentry. |
Yes, in the partials we could use ViewComponents, but partials are way easier to overwrite than ViewComponents |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this pull request for?
The dashboard has now partials for each part (
top,left_column,right_column) and widgets for the content placed into them. It looks the same as before, but can now be changed in the host app or extensions by overwriting on of the partials.Checklist