Prevent Javascript error if the page will be unlocked #2942
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make an undefined check to the locked status label which is only available in page tree view. If user is closing the tab in page edit view (or any other view) it will result in a javascript error.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2942 +/- ##
=======================================
Coverage 95.96% 95.96%
=======================================
Files 232 232
Lines 6272 6272
=======================================
Hits 6019 6019
Misses 253 253 ☔ View full report in Codecov by Sentry. |
tvdeyen
approved these changes
Jun 27, 2024
tvdeyen
added
backport-to-7.1-stable
This was referenced Jun 27, 2024
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation and see the Github Action logs for details |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this pull request for?
Make an undefined check to the locked status label which is only available in page tree view. If user is closing the tab in page edit view (or any other view) it will result in a javascript error.
Checklist