Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed 3 broken links, 1 still needs fixing. #2924

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion app/views/alchemy/welcome.html.erb
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@
</p>
<ul>
<li><%= link_to 'Create your first admin user', Alchemy.signup_path %></li>
<li><%= link_to 'Read the guidelines', 'http://guides.alchemy-cms.com/stable', target: '_blank' %></li>
<li><%= link_to 'Read the guidelines', 'http://guides.alchemy-cms.com', target: '_blank' %></li>
</ul>
</div>
</body>
Expand Down
2 changes: 1 addition & 1 deletion lib/generators/alchemy/install/templates/elements.yml.tt
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# == In this configuration, you set up Alchemy's element layouts.
#
# For further information please see http://guides.alchemy-cms.com/stable/elements.html
# For further information please see http://guides.alchemy-cms.com/elements.html

<%- unless @options[:skip_demo_files] -%>
- name: article
Expand Down
3 changes: 2 additions & 1 deletion lib/generators/alchemy/install/templates/menus.yml.tt
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
# == In this configuration, you set up Alchemy's menu names.
#
# For further information please see http://guides.alchemy-cms.com/stable/menus.html
# TODO: Ensure there is a working link with explanation on how menu's are constructed. Link below is broken.
# For further information please see http://guides.alchemy-cms.com/menus.html
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is no guide unfortunately. Can we remove the comment altogether for now?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am a new person testing out Alchemy having this undocumented is super confusing as this is very core to any webpage.

After looking a bit on the code I found what to do.

What about instead having the links say: To create the views for the menu use rails g alchemy:menus and render the menu with <%= render_menu('menu_name') %>

At least this comment with get the people going for common use cases.


<%- unless @options[:skip_demo_files] -%>
- main_menu
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# == This file defines the page layouts for new pages.
#
# For further information please see http://guides.alchemy-cms.com/stable/page_layouts.html
# For further information please see http://guides.alchemy-cms.com/page_layouts.html

<%- unless @options[:skip_demo_files] -%>
- name: <%= Alchemy::Config.get(:default_language)['page_layout'] %>
Expand Down
Loading