Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace picture css class after update #2917

Merged
merged 3 commits into from
Jun 5, 2024
Merged

Conversation

tvdeyen
Copy link
Member

@tvdeyen tvdeyen commented Jun 4, 2024

What is this pull request for?

We display the css class on the picture ingredient editor.
If the use updates the class, we need to update the label.

Notable changes (remove if none)

Use translated css class for select options unless already passed as key, value pairs.

Screenshots

Also updates the layout for better legibility

Alchemy CMS - Startseite 2024-06-04 22-34-49

We display the css class on the picture ingredient editor.
If the use updates the class, we need to update the label.
Add a icon and use darker background for better legibility.
@tvdeyen tvdeyen requested a review from a team as a code owner June 4, 2024 20:37
@tvdeyen tvdeyen added the backport-to-7.2-stable Needs to be backported to 7.2-stable label Jun 4, 2024
Copy link

codecov bot commented Jun 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.97%. Comparing base (0e8d250) to head (81d02df).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2917   +/-   ##
=======================================
  Coverage   95.97%   95.97%           
=======================================
  Files         232      232           
  Lines        6279     6279           
=======================================
  Hits         6026     6026           
  Misses        253      253           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tvdeyen tvdeyen merged commit 13d45be into main Jun 5, 2024
37 checks passed
@tvdeyen tvdeyen deleted the update-picture-css-class branch June 5, 2024 07:08
@tvdeyen tvdeyen removed the backport-to-7.2-stable Needs to be backported to 7.2-stable label Sep 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants