Add Language and Site serializers #2900
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without those ActiveModelSerializers can't find a serializer for the site and language relations in the PageSerializer which is used in the PageSelect. It delegates serialization to Rails which takes whatever serializer is responsible for to_json, which in some cases lead to nesting the site or language with it's own root key, which is not what we want.
tvdeyen
force-pushed
the
add-site-and-language-serializers
branch
from
3c412fd
to
1447087
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2900 +/- ##
=======================================
Coverage 95.96% 95.96%
=======================================
Files 230 232 +2
Lines 6269 6275 +6
=======================================
+ Hits 6016 6022 +6
Misses 253 253 ☔ View full report in Codecov by Sentry. |
mamhoff
approved these changes
May 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this pull request for?
Without those ActiveModelSerializers can't find a serializer for the site and language relations in the PageSerializer which is used in the PageSelect. It delegates serialization to Rails which takes whatever serializer is responsible for to_json, which in some cases lead to nesting the site or language with it's own root key, which is not what we want.
Checklist