fix(InternalTab): Fix for urls with trailing slash and no locale #2897
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tvdeyen
force-pushed
the
fix-internal-tab-regexp
branch
from
84988f9
to
2b500aa
Compare
The former regexp was ignoring the second slash in urls without locale but with trailing slash, since it was not part of the locale group and optional. Using a non match group for the optional locale and it's optional slash. Co-authored-by: Martin Meyerhoff <mamhoff@gmail.com> Co-authored-by: ChatGPT <chat@openai.com>
tvdeyen
force-pushed
the
fix-internal-tab-regexp
branch
from
2b500aa
to
8ce686e
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2897 +/- ##
=======================================
Coverage 95.96% 95.96%
=======================================
Files 230 230
Lines 6269 6269
=======================================
Hits 6016 6016
Misses 253 253 ☔ View full report in Codecov by Sentry. |
sascha-karnatz
approved these changes
May 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this pull request for?
The former regexp was ignoring the second slash in urls
without locale but with trailing slash, since it was not part
of the locale group and optional. Using a non match group
for the optional locale and it's optional slash.
Checklist