Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support trailing slash in internal link tab selection #2895

Merged
merged 1 commit into from
May 27, 2024

Conversation

tvdeyen
Copy link
Member

@tvdeyen tvdeyen commented May 24, 2024

What is this pull request for?

☝🏻

Checklist

  • I have followed Pull Request guidelines
  • I have added a detailed description into each commit message
  • I have added tests to cover this change

@tvdeyen tvdeyen requested a review from a team as a code owner May 24, 2024 10:46
@tvdeyen tvdeyen added this to the 7.2 milestone May 24, 2024
@tvdeyen tvdeyen enabled auto-merge May 24, 2024 10:48
@tvdeyen
Copy link
Member Author

tvdeyen commented May 27, 2024

Specs fixed in #2896

@tvdeyen tvdeyen force-pushed the internal-link-trailing-slash branch from 4725bf6 to f2c2405 Compare May 27, 2024 09:23
Copy link

codecov bot commented May 27, 2024

Codecov Report

All modified and coverable lines are covered by tests βœ…

Project coverage is 95.96%. Comparing base (4bf0fa9) to head (f2c2405).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2895   +/-   ##
=======================================
  Coverage   95.96%   95.96%           
=======================================
  Files         230      230           
  Lines        6269     6269           
=======================================
  Hits         6016     6016           
  Misses        253      253           

β˜” View full report in Codecov by Sentry.
πŸ“’ Have feedback on the report? Share it here.

@tvdeyen tvdeyen merged commit a7f8903 into main May 27, 2024
35 checks passed
@tvdeyen tvdeyen deleted the internal-link-trailing-slash branch May 27, 2024 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants