Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(dialog-link): Do not addEventListener on every DOM insert #2874

Merged
merged 1 commit into from
May 15, 2024

Conversation

tvdeyen
Copy link
Member

@tvdeyen tvdeyen commented May 15, 2024

Doing that we get an additional event handler whenever we move the element in the DOM. Via dragndrop of an element editor for example.


Doing that we get an additional event handler whenever we move the element
in the DOM. Via dragndrop of an element editor for example.
@tvdeyen tvdeyen added the bug label May 15, 2024
@tvdeyen tvdeyen added this to the 7.2 milestone May 15, 2024
@tvdeyen tvdeyen requested a review from a team as a code owner May 15, 2024 16:00
Copy link

codecov bot commented May 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.93%. Comparing base (6af974a) to head (16c39d1).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2874      +/-   ##
==========================================
- Coverage   95.93%   95.93%   -0.01%     
==========================================
  Files         229      229              
  Lines        6224     6222       -2     
==========================================
- Hits         5971     5969       -2     
  Misses        253      253              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tvdeyen tvdeyen merged commit 0f49374 into AlchemyCMS:main May 15, 2024
36 of 37 checks passed
@tvdeyen tvdeyen deleted the fix-dialog-link-double-open branch May 15, 2024 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants