Convert legacy page urls panel into Turbo Frame #2867
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2867 +/- ##
==========================================
+ Coverage 95.88% 95.93% +0.05%
==========================================
Files 229 229
Lines 6218 6222 +4
==========================================
+ Hits 5962 5969 +7
+ Misses 256 253 -3 ☔ View full report in Codecov by Sentry. |
tvdeyen
force-pushed
the
turbo-frame-legacy-page-urls
branch
from
691e04e
to
07fdbe1
Compare
Allows to build a table out of divs instead of table tags. Useful for cases where a table markup is not possible. If you want to use a turbo-frame per row for example.
Sometimes you dont want to use an alchemy_form_for, because the form is not using features from it (ie. remote: true)
Uses turbo frames instead of a remote form to get rid js.erb templates and use turbo streams instead.
tvdeyen
force-pushed
the
turbo-frame-legacy-page-urls
branch
from
07fdbe1
to
520fd8e
Compare
tvdeyen
changed the title
mamhoff
approved these changes
May 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this pull request for?
Uses turbo frames instead of a remote form to get rid
js.erbtemplates and use turbo streams instead.screencast.2024-05-09.17-57-05.mp4
Checklist