Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove render_flash_notice helper #2857

Merged
merged 1 commit into from
May 2, 2024
Merged

Conversation

tvdeyen
Copy link
Member

@tvdeyen tvdeyen commented May 1, 2024

What is this pull request for?

Since we only used this internally we can simply remove this, instead of deprecating it.

If you used this helper anyway, please

render Alchemy::Admin::Message.new(message, type: flash_type, dismissable: true)

instead.

Checklist

Since we only used this internally we can simply remove this,
instead of deprecating it.

If you used this helper anyway, please

    render Alchemy::Admin::Message.new(message, type: flash_type, dismissable: true)

instead.
@tvdeyen tvdeyen requested a review from a team as a code owner May 1, 2024 20:17
@tvdeyen tvdeyen added this to the 7.2 milestone May 1, 2024
@tvdeyen tvdeyen enabled auto-merge May 1, 2024 20:17
Copy link

codecov bot commented May 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.86%. Comparing base (f123201) to head (640ddc0).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2857      +/-   ##
==========================================
- Coverage   95.86%   95.86%   -0.01%     
==========================================
  Files         229      229              
  Lines        6211     6209       -2     
==========================================
- Hits         5954     5952       -2     
  Misses        257      257              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tvdeyen tvdeyen merged commit 145c570 into main May 2, 2024
36 checks passed
@tvdeyen tvdeyen deleted the remove-render_flash_notice branch May 2, 2024 06:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants