Add delete-element-button #2818
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2818 +/- ##
==========================================
- Coverage 95.92% 95.92% -0.01%
==========================================
Files 225 225
Lines 6129 6128 -1
==========================================
- Hits 5879 5878 -1
Misses 250 250 ☔ View full report in Codecov by Sentry. |
Do not use global Alchemy object anymore and fix a bug with nested dirty elements not being detected.
Replaces a js.erb template returned from the controller. In order for this to work we return a promise from confirmToDeleteDialog that gets resolved after the DELETE request has been made.
No need for jQuery.hide animation here.
tvdeyen
force-pushed
the
delete-element-button
branch
from
9fc8d1c
to
5e789e0
Compare
sascha-karnatz
approved these changes
Apr 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this pull request for?
Instead returning imperative JS from a
js.erbserver response (that only works with the deprecatedrails-ujslibrary)we introduce another web component that uses the also introduced
ConfirmDialogES class and a promised basedapproach to do the things we do after we removed an element.
Checklist