Refactor link dialog into ES module #2796
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2796 +/- ##
==========================================
+ Coverage 95.90% 95.92% +0.01%
==========================================
Files 225 225
Lines 6103 6129 +26
==========================================
+ Hits 5853 5879 +26
Misses 250 250 ☔ View full report in Codecov by Sentry. |
sascha-karnatz
force-pushed
the
link-dailog-improvements
branch
3 times, most recently
from
9315da2
to
dbfe1a7
Compare
tvdeyen
changed the title
tvdeyen
changed the title
tvdeyen
reviewed
Mar 22, 2024
sascha-karnatz
force-pushed
the
link-dailog-improvements
branch
from
fac431e
to
601bab5
Compare
3 tasks
sascha-karnatz
force-pushed
the
link-dailog-improvements
branch
from
601bab5
to
75a21e8
Compare
tvdeyen
requested changes
Mar 22, 2024
sascha-karnatz
force-pushed
the
link-dailog-improvements
branch
from
b794403
to
d964b98
Compare
Should work now |
sascha-karnatz
force-pushed
the
link-dailog-improvements
branch
2 times, most recently
from
4edaf72
to
955708d
Compare
tvdeyen
reviewed
Mar 26, 2024
sascha-karnatz
force-pushed
the
link-dailog-improvements
branch
2 times, most recently
from
81ad9d5
to
875ba7f
Compare
Use our default page select web component also in the link dialog. This simplifies the link dialog (a bit) and removes an Handlebar template, which isn't necessary anymore.
Remove the Javascript code which selected the tab in link dialog and moved it into the view components. Also prefilled the forms to remove these part as well from the Coffeescript.
Moved the dom id - logic into a separate web component. This reduce the amount of necessary Javascript in link dialog and moves that into a isolated web component.
The link dialog was handling the link button and the TinyMCE implementation. Now the dialog is working with a promise and will respond to the caller with the link configuration. The calling method can make the decision to insert the link into her environment.
Migrate the Link Dialog from CoffeeScript to Javascript. This will also trim the internal class structure a bit to be better readable.
remove the usage of jQuery in LinkDialog and replace it with vanilla Javascript. Also restructure smaller parts of the class to improve the overview.
sascha-karnatz
force-pushed
the
link-dailog-improvements
branch
from
875ba7f
to
0fba444
Compare
sascha-karnatz
force-pushed
the
link-dailog-improvements
branch
from
0fba444
to
4f734be
Compare
tvdeyen
requested changes
Mar 28, 2024
tvdeyen
reviewed
Mar 28, 2024
app/assets/javascripts/tinymce/plugins/alchemy_link/plugin.min.js
Outdated
Show resolved
Hide resolved
tvdeyen
approved these changes
Mar 28, 2024
| #createLink(linkOptions) { | ||
| const invalidInput = | ||
| linkOptions.type === "external" && | ||
| !linkOptions.url.match(Alchemy.link_url_regexp) |
There was a problem hiding this comment.
we should validate earlier in the submit form event
It was previously a dom id - select and technically it is search for dom nodes with ids. It also adds an enabled and disabled state on the dom id - select. Also separate both dom id selects into slightly different components and add an enable and disable mechanic to alchemy-select.
sascha-karnatz
force-pushed
the
link-dailog-improvements
branch
3 times, most recently
from
653cf26
to
9db3ab8
Compare
tvdeyen
reviewed
Mar 29, 2024
sascha-karnatz
force-pushed
the
link-dailog-improvements
branch
from
9db3ab8
to
97b3056
Compare
Remove unnecessary data-link-target - attribute. It is not necessary anymore and can be removed. Also the support for different kinds of targets was added like _top, _self, etc. Also remove a lot of unnecessary transformation and store target with the default HTML syntax.
sascha-karnatz
force-pushed
the
link-dailog-improvements
branch
from
97b3056
to
4dc39a2
Compare
tvdeyen
approved these changes
Apr 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this pull request for?
Checklist