Moved the link dialog partials into view components #2766
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sascha-karnatz
force-pushed
the
link-tab-components
branch
from
953fe29
to
1fde2e9
Compare
tvdeyen
reviewed
Mar 4, 2024
sascha-karnatz
force-pushed
the
link-tab-components
branch
from
1264b63
to
d129fbc
Compare
Try to migrate the link dialog partials into view component to make it easier extendable and lesser repetitive.
Provide a configuration to configure the tabs in the link dialog. It is now possible to add new tabs without overwriting or defacing the Admin UI.
Move the last piece of the link view to a view component and remove the original view.
sascha-karnatz
force-pushed
the
link-tab-components
branch
from
182cd7b
to
e1c200e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this pull request for?
Try to migrate the link dialog partials into view component to make it easier extendable and lesser repetitive. Add a configuration possibility to add new tabs to the link dialog, without overwriting or defacing.
This an extraction of PR #2756
Checklist