Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix sortable elements #2750

Merged
merged 2 commits into from
Feb 27, 2024
Merged

Commits on Feb 26, 2024

  1. Fix sorting of nested elements of freshly created elements

    Make sure that nested elements of all elements get initialized
    as sortable after being created, not just fixed.
    tvdeyen committed Feb 26, 2024
    Configuration menu
    Copy the full SHA
    df533be View commit details
    Browse the repository at this point in the history

Commits on Feb 27, 2024

  1. Avoid sending sort events twice

    SortableJS sends two events if you drag an element from one
    nesteable elements container to another. Leading to incrementing
    the target lists positions to high.
    
    Since acts_as_list maintains both lists correctly we can simply
    suppress the second event on the source list.
    tvdeyen committed Feb 27, 2024
    Configuration menu
    Copy the full SHA
    fa8a966 View commit details
    Browse the repository at this point in the history