Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TinyMCE: Trim spaces from pasted links #2702

Merged
merged 1 commit into from
Jan 22, 2024

Conversation

mamhoff
Copy link
Contributor

@mamhoff mamhoff commented Jan 22, 2024

What is this pull request for?

It's a common occurrence for pasted content to contain a space at the end. For links, this can make the links invalid, as TinyMCE will URL-encode that space and make it meaningful - even though it is not.

This commit trims whitespace from URLs before setting them in TinyMCE.

Checklist

It's a common occurrence for pasted content to contain a space at the
end. For links, this can make the links invalid, as TinyMCE will
URL-encode that space and make it meaningful - even though it is not.

This commit trims whitespace from URLs before setting them in TinyMCE.
Copy link
Member

@tvdeyen tvdeyen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. Thanks

@tvdeyen tvdeyen added the backport-to-7.0-stable Needs to be backported to 7.0-stable label Jan 22, 2024
@tvdeyen tvdeyen merged commit 03641d4 into AlchemyCMS:main Jan 22, 2024
35 checks passed
@alchemycms-bot
Copy link
Collaborator

💔 All backports failed

Status Branch Result
7.0-stable Backport failed because of merge conflicts

Manual backport

To create the backport manually run:

backport --pr 2702

Questions ?

Please refer to the Backport tool documentation and see the Github Action logs for details

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-to-7.0-stable Needs to be backported to 7.0-stable
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants