Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set admin picture thumbnail quality to 90 #2692

Merged
merged 2 commits into from
Jan 16, 2024

Conversation

tvdeyen
Copy link
Member

@tvdeyen tvdeyen commented Jan 16, 2024

What is this pull request for?

Make the picture thumbnail quality independent from the
frontend output_image_quality config.

Using 90 as value for quality should be a good compromise
between file size and image quality.

The same image with quality of 100 is three times the size of an image with quality of 90 while having nearly the same image
quality for a small thumbnail. An large thumbnail (as used in the
image cropper) is ten times the size in 100% quality!

Checklist

  • I have followed Pull Request guidelines
  • I have added a detailed description into each commit message
  • I have added tests to cover this change

Returns an url for the thumbnail representation of the picture
Make the picture thumbnail quality independent from the
frontend output_image_quality config.

Using 90 as value for quality should be a good compromise
between file size and image quality.

The same image with quality of 100 is three times the size of an image with quality of 90 while having nearly the same image
quality for a small thumbnail. An large thumbnail (as used in the
image cropper) is ten times the size in 100% quality!
@tvdeyen tvdeyen added this to the 7.1 milestone Jan 16, 2024
@tvdeyen tvdeyen requested a review from a team January 16, 2024 13:48
@tvdeyen tvdeyen merged commit 1d81e7f into AlchemyCMS:main Jan 16, 2024
34 checks passed
@tvdeyen tvdeyen deleted the admin-thumbnail-quality branch January 16, 2024 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants