Download and bundle third party JS packages with npm #2679
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
importmap-rails allows to download pinned assets instead of serving them via CDN. We want to do that for several reasons: - Reliability - GDPR - Speed
This function is so small that using lodash is not worth it.
And remove lodash-max
We do not use it anymore
importmap-rails v2 will have this as default as well.
It is not possible to pin and download shoelace with importmap-rails. Since it is more efficient to have a bundle anyway and depency management via yarn much easier than with importmap-rails we install it via yarn and build it with rollup. This can easyliy be automated with github actions, so we have best of all worlds.
We already build our own optimized shoelace package. Since we already use yarn to handle dependencies we download all of our third party dependencies and build a packages for them and make them available via source map. That way we can make use of automated dependency updates (like dependabot) and automatically build the packages with github actions. That would be significantly harder with importmap- rails.
This makes the bundled packages significantly smaller.
This way we can use npm as dependency manager and omit loading each plugin on its own
Instead of a downloaded version from vendor/assets folder. So we can use established tools for dependency updates.
This way our JS dependencies get version updates. After new versions installed build new packages.
All browsers support it now.
tvdeyen
changed the title
![codeclimate[bot]](https://avatars.githubusercontent.com/in/9403?s=60&v=4){kind=small}
We do not need these files in the package Rubygem. The yarn.lock is very large and all the dot files are only necessary for local development.
Now that we have modules in `vendor/javascript` and in `vendor/assets/javascripts` we need to change the module mapping for jest specs.
We maybe want to add JS dependencies in PRs not only through dependabot PRs.
tvdeyen
force-pushed
the
download-imported-pins
branch
from
9aa77d6
to
de43594
Compare
tvdeyen
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this pull request for?
Do not use CDNs any more to load ShoelaceJS or use downloaded and vendored third party scripts.
This fixes issues with
etcpp.
Notable changes
We now use npm to download and manage JS dependencies and Rollup to build packages that we then import
via importmaps.
Checklist