Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix error linking text in tinymce #2676

Merged
merged 1 commit into from
Jan 8, 2024

Conversation

tvdeyen
Copy link
Member

@tvdeyen tvdeyen commented Jan 8, 2024

What is this pull request for?

When the text does not have a link yet and also is a object from tinymce editor it does not have the getAttribute function. We can simply check for its existance.

Checklist

  • I have followed Pull Request guidelines
  • I have added a detailed description into each commit message
  • I have added tests to cover this change

When the text does not have a link yet and also is a object
from tinymce editor it does not have the getAttribute function.
We can simply check for its existance.
@tvdeyen tvdeyen requested a review from a team January 8, 2024 07:48
@tvdeyen tvdeyen added the bug label Jan 8, 2024
@tvdeyen tvdeyen merged commit 86d0d0d into AlchemyCMS:main Jan 8, 2024
32 checks passed
@tvdeyen tvdeyen deleted the fix-link-text-in-tinymce branch January 8, 2024 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants