Fix many layouts glitches #2652
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was accidentally removed
We do not want to have a bottom border when element is collapsed. Since elements can be nested a selector like this is hard to write. Adding the border to the toolbar instead, since this is hidden if element is collapsed.
Sometime on redraw (during dragndrop) the select does not have the correct width anymore. Since we always want the choice to be as wide as the container the fix is simple.
With the usage of Shoelace tabs we adjusted the padding of the tabbed panels, but this is too high. Also we now highlight the sortable elements area for which we need more padding now.
The thumbnail background color has changed to a light gray. The spinner now needs to be dark again.
We most not use width 100% here. The svg already has the fix.
If there is no language and no site select we need to move the tooltip
We do not use jquery-ui-sortable anymore.
The padding will cut of content on headline ingredients
Sortable needs to be created for nested elements in a fixed element, not the fixed element itself.
We need to calculate the height for fixed elements differently than main content elements, because we want to fixate the tab bar.
With many tags this list peaks out of the dialog.
It needs to be wrapped in a toolbar-button for the margin it needs.
sascha-karnatz
approved these changes
Dec 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this pull request for?
Over the last couple of weeks we made a lot of changes to our UI elements.
This fixes glitches this work introduced.
Best reviewed commit by commit.
Checklist