Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix element states styling #2636

Merged
merged 4 commits into from
Dec 12, 2023
Merged

Conversation

tvdeyen
Copy link
Member

@tvdeyen tvdeyen commented Dec 12, 2023

What is this pull request for?

See list of commits

Checklist

  • I have followed Pull Request guidelines
  • I have added a detailed description into each commit message
  • I have added tests to cover this change

An element should never make its parent element dirty in order
to not be confused which element needs to be saved. Make the
nested element header show the dirty state as well.
@tvdeyen tvdeyen added this to the 7.1 milestone Dec 12, 2023
@tvdeyen tvdeyen requested a review from a team December 12, 2023 14:46
- Slighty fade content of hidden elements
- Use correct label if element is hidden
- Hide hidden state label in compact elements
Make unselected elements blend better into the background
@tvdeyen tvdeyen merged commit 2483440 into AlchemyCMS:main Dec 12, 2023
31 checks passed
@tvdeyen tvdeyen deleted the fix-element-dirty branch December 12, 2023 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants