Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use rails-ujs instead of jquery_ujs #2619

Merged
merged 1 commit into from
Nov 24, 2023
Merged

Conversation

tvdeyen
Copy link
Member

@tvdeyen tvdeyen commented Nov 24, 2023

What is this pull request for?

Use Rails' unobstrusive scripting adapater without jQuery.

The event response of the custom "ajax:" events have changed, so we have to adopt. Otherwise it is a drop in replacement.

Checklist

Use Rails' unobstrusive scripting adapater without jQuery.

The event response of the custom "ajax:" events have changed, so
we have to adopt. Otherwise it is a drop in replacement.
@tvdeyen tvdeyen added this to the 7.1 milestone Nov 24, 2023
@tvdeyen tvdeyen requested a review from a team November 24, 2023 09:20
Copy link
Contributor

@sascha-karnatz sascha-karnatz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One less jQuery - dependency

@tvdeyen tvdeyen merged commit 8d23973 into AlchemyCMS:main Nov 24, 2023
31 checks passed
@tvdeyen tvdeyen deleted the rails-ujs branch November 24, 2023 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants