[7.0-stable] Merge pull request #2612 from sascha-karnatz/harden-page-publisher #2613
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The idea is to provide a possibility to lock a page inside a transaction to prevent, that two (or more) processes working on the same page. This will be included into the Page::Publisher to prevent, that in parallel running worker are updating the same page and creating duplicate entries. This implementation is heavily inspired by Solidus Spree::OrderMutex. (cherry picked from commit 61d7974)
Prevent publishing the same page at the same time. The PageMutex is locking the page for the time it takes until the page is published. After that the lock is released and it can publish again. (cherry picked from commit 0d8b119)
The CI test pipeline breaks for Rails 7.1. The eager loading results into a Zeitwerk error in the turbo-rails gem. The current solution is to include actioncable if the application is running in a Github Action until this bug is fixed. Ref: hotwired/turbo-rails#512 (cherry picked from commit 8fe1bb3)
3 tasks
tvdeyen
approved these changes
Nov 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport
This will backport the following commits from
mainto7.0-stable:Questions ?
Please refer to the Backport tool documentation