Allow to import additional admin JS modules #2588
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robinboening
approved these changes
Oct 4, 2023
Yeah. Actually it is a bug in Alchemy 7.0 for all non english speaking users, because the Flatpickr translations are not present anymore 🙈 |
In order to be able to import additional JS modules
into the Alchemy admin UI you can use this.
Be sure to also pin the modules with `Alchemy.importmap`.
\## Example
Alchemy.importmap.pin "flatpickr/de",
to: "https://ga.jspm.io/npm:flatpickr@4.6.13/dist/l10n/de.js"
Alchemy.admin_js_imports << "flatpickr/de"
tvdeyen
force-pushed
the
admin-js-imports
branch
from
e44663d
to
79131fc
Compare
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation and see the Github Action logs for details |
tvdeyen
added a commit
that referenced
this pull request
Oct 4, 2023
[7.0-stable] Merge pull request #2588 from tvdeyen/admin-js-imports
tvdeyen
added a commit
to AlchemyCMS/alchemy_i18n
that referenced
this pull request
Oct 4, 2023
We need at least Alchemy 7.0.4 for the ability to add additional admin JS module imports. See AlchemyCMS/alchemy_cms#2588
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to be able to import additional JS modules into the Alchemy admin UI you can use this.
Be sure to also pin the modules with
Alchemy.importmap.Example