Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[7.0] Bugfix: Init PagePublicationFields on Pages Table #2533

Merged

Conversation

tvdeyen
Copy link
Member

@tvdeyen tvdeyen commented Jul 31, 2023

Same as #2528 but for 7.0-stable

tvdeyen and others added 5 commits July 6, 2023 10:15
Before we were removing the intersection observer even
if we are still on the same page.

Now removing it were we need to, in the Turbo page change
event.
[v7.0] Use selenium-webdriver instead of webdrivers gem
On the Sitemap and on the Edit page, `Alchemy::PagePublicationFields` is
initialized. On the table, it isn't, leading to behavior where an admin cannot
un-publish or publish a page from the pages table.
@tvdeyen tvdeyen changed the title 7.0 fix page publication fields on pages table [7.0] Bugfix: Init PagePublicationFields on Pages Table Jul 31, 2023
@tvdeyen tvdeyen merged commit 6ef5130 into AlchemyCMS:main Jul 31, 2023
23 checks passed
@tvdeyen tvdeyen deleted the 7.0-fix-page-publication-fields-on-pages-table branch July 31, 2023 14:51
@tvdeyen tvdeyen restored the 7.0-fix-page-publication-fields-on-pages-table branch July 31, 2023 17:38
@tvdeyen tvdeyen deleted the 7.0-fix-page-publication-fields-on-pages-table branch July 31, 2023 19:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants