Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

convert Initializer from Coffeescript to Javascript #2513

Merged

Conversation

sascha-karnatz
Copy link
Contributor

What is this pull request for?

Move the initializer also into the Javascript folder. It make sense to move the higher level Javascript first, because this will prevent loading raise conditions.

Checklist

  • I have followed Pull Request guidelines
  • I have added a detailed description into each commit message
  • I have added tests to cover this change

@sascha-karnatz sascha-karnatz force-pushed the move-initialize-into-app-javascript branch from 5ad4672 to 822f9dd Compare July 4, 2023 08:52
@tvdeyen tvdeyen added this to the 7.1 milestone Jul 4, 2023
@sascha-karnatz sascha-karnatz force-pushed the move-initialize-into-app-javascript branch 2 times, most recently from f95b5aa to 26ef30c Compare July 6, 2023 06:54
@tvdeyen
Copy link
Member

tvdeyen commented Jul 31, 2023

@sascha-karnatz needs a rebase now that #2509 has been merged

Move the initializer also into the Javascript folder. It make sense to move the higher level Javascript first, because this will prevent loading raise conditions.
@sascha-karnatz sascha-karnatz force-pushed the move-initialize-into-app-javascript branch from 26ef30c to 9631077 Compare July 31, 2023 14:12
@tvdeyen tvdeyen merged commit 20cd782 into AlchemyCMS:main Jul 31, 2023
23 checks passed
@sascha-karnatz sascha-karnatz deleted the move-initialize-into-app-javascript branch August 2, 2023 06:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants