Replace turbolinks with turbo #2499
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sascha-karnatz
force-pushed
the
replace-turbolinks-with-turbo
branch
from
2b1a48b
to
5c44481
Compare
sascha-karnatz
changed the title
tvdeyen
reviewed
Jun 29, 2023
| @@ -20,7 +20,7 @@ | |||
|
|
|||
| <% if element.editable? %> | |||
| <%= form_for [alchemy, :admin, element], remote: true, | |||
| html: {id: "element_#{element.id}_form".html_safe, class: 'element-body'} do |f| %> | |||
| html: {id: "element_#{element.id}_form".html_safe, class: 'element-body', 'data-turbo': false} do |f| %> | |||
There was a problem hiding this comment.
I think this can be removed now that we use the "turbo:load" event in pages/edit.html.erb
Turbolinks is archived and was replaced by Turbo. All Turbolinks usages are replace by Turbo Drive for now.
sascha-karnatz
force-pushed
the
replace-turbolinks-with-turbo
branch
from
5c44481
to
a236c26
Compare
tvdeyen
approved these changes
Jun 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this pull request for?
Replace Turbolinks with Turbo. Turbolinks are deprecated and the newer implementation of the same technique is Turbo.
Notable changes (remove if none)
Checklist