Use Importmaps for admin JS #2498
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows us to get rid of the bundling of our npm module and the necessity of bundling in the host app.
sascha-karnatz
approved these changes
Jun 28, 2023
tvdeyen
force-pushed
the
importmaps-support
branch
from
352762a
to
da5252a
Compare
tvdeyen
force-pushed
the
importmaps-support
branch
2 times, most recently
from
12ad2d3
to
38e5308
Compare
We now serve the admin js via importmaps. Look at this diff. Nothing else to add.
Lots of this is taken from solidusio/solidus@64de7bd
Follows Rails conventions and removes potential conflicts.
We only use it on the nodes page and do not need to make globally available thanks to script type module \o/
This makes it easier to import individual modules
We pinned all JS files under app/javascript into importmap and do not want to load test files.
tvdeyen
force-pushed
the
importmaps-support
branch
from
67850e6
to
4644b75
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this pull request for?
Use
importmap-railsto serve our admin ESM based JS.Notable changes
Removes the
@alchemy_cms/adminnpm package and all related code. 🥳In existing installations please run
to remove all alchemy_admin package related code (and optionally webpacker)
Closes #2467