[6.1] Fix page seeder #2482
Merged
[6.1] Fix page seeder #2482
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ruby 3.1 does not allow Date in yml by default anymore.
If you pass a public_on date to the page seeder, Alchemy will create a public version (because of the public_on= attribute writer). The before_create filter kicks in too late, leading to public pages without a draft version. Tried to use different before filters in the page model, but nothing worked. So I fixed the problem where it happens in the page seeder.
tvdeyen
force-pushed
the
6.1-fix-page-seeder
branch
from
fe847d7
to
a9a49ab
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Same as #2389 but for 6.1