Use view_component for ingredient views #2465
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tvdeyen
commented
May 5, 2023
tvdeyen
commented
May 5, 2023
tvdeyen
commented
May 5, 2023
tvdeyen
force-pushed
the
view-components
branch
3 times, most recently
from
1fdb549
to
d1eed03
Compare
tvdeyen
changed the title
tvdeyen
commented
May 10, 2023
tvdeyen
commented
May 10, 2023
tvdeyen
commented
May 10, 2023
tvdeyen
commented
May 10, 2023
Make it more obvious what options are for the component view and which are we passing to the picture#url method.
Need that in order for editors with autoformatting work correctly. We use standardrb to format, but that uses rubocop to lint.
Instead of rendering the view partial of the ingredient we render it view component instead. Deprecates the ingredients view partials.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this pull request for?
Introduce View Components as View classes for Ingredients.
Notable changes (remove if none)
Stops rendering the
_viewpartial for ingredients underapp/views/alchemy/ingredients.Deprecates render the ingredient view directly.