Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add searchable field to page #2414

Merged

Conversation

kulturbande
Copy link
Contributor

@kulturbande kulturbande commented Jan 20, 2023

Allow to toggle searchable field on page level. The field is only available if it was enabled in the Alchemy - module. The information can be used by search plugins (e.g. https://github.com/AlchemyCMS/alchemy-pg_search).

What is this pull request for?

  • store a searchable flag on the page entity
  • toggle the visibility of the checkbox in Alchemy - module

Screenshots

Aufnahme 2023-01-20 at 10 54 06@2x

Checklist

  • I have followed Pull Request guidelines
  • I have added a detailed description into each commit message
  • I have added tests to cover this change

@kulturbande kulturbande force-pushed the feature/add-searchable-field-to-page branch from 57ec4db to 90da3e1 Compare January 20, 2023 10:50
kulturbande added a commit to kulturbande/alchemy-pg_search that referenced this pull request Jan 20, 2023
It is possible to remove pages from the index that have a disabled searchable - flag. This is the companion commit to the PR in Alchemy CMS.

Reference: AlchemyCMS/alchemy_cms#2414
Copy link
Member

@tvdeyen tvdeyen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. One comment.

spec/features/admin/page_editing_feature_spec.rb Outdated Show resolved Hide resolved
@tvdeyen
Copy link
Member

tvdeyen commented Jan 23, 2023

@kulturbande need a rebase, because A LOT has changed in current main branch

Allow to toggle searchable field on page level. The field is only available if it was enabled in the Alchemy - module. The information can be used by search plugins (e.g. https://github.com/AlchemyCMS/alchemy-pg_search).
@kulturbande kulturbande force-pushed the feature/add-searchable-field-to-page branch from 90da3e1 to 4ed4853 Compare January 23, 2023 10:58
@tvdeyen tvdeyen merged commit e76b2f0 into AlchemyCMS:main Jan 23, 2023
kulturbande added a commit to kulturbande/alchemy-pg_search that referenced this pull request Jan 23, 2023
It is possible to remove pages from the index that have a disabled searchable - flag. This is the companion commit to the PR in Alchemy CMS.

Reference: AlchemyCMS/alchemy_cms#2414
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants