Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a error logger exception handler #2387

Merged
merged 1 commit into from
Dec 6, 2022
Merged

Add a error logger exception handler #2387

merged 1 commit into from
Dec 6, 2022

Conversation

tvdeyen
Copy link
Member

@tvdeyen tvdeyen commented Nov 24, 2022

What is this pull request for?

A new default exception handler logs into the Rails log.

Checklist

  • I have followed Pull Request guidelines
  • I have added a detailed description into each commit message
  • I have added tests to cover this change

@tvdeyen
Add a error logger exception handler
5a16257 
A new default exception handler logs into the Rails log.
@tvdeyen tvdeyen requested a review from mamhoff November 24, 2022 10:22
mamhoff
mamhoff approved these changes Dec 6, 2022
View reviewed changes
Copy link
Contributor

@mamhoff mamhoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assuming this can be configured by apps using Alchemy, this looks great!

@tvdeyen
Copy link
Member Author

tvdeyen commented Dec 6, 2022

Assuming this can be configured by apps using Alchemy, this looks great!

Yes, since 6.0.12 #2220

@tvdeyen tvdeyen merged commit 4208b94 into AlchemyCMS:main Dec 6, 2022
@tvdeyen tvdeyen deleted the error-tracking-log-by-default branch December 6, 2022 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mamhoff mamhoff mamhoff approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tvdeyen @mamhoff