Always provide format with attachment URLs #2383
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When linking to an attachment without the format, the browser does not necessarily know what to do with the file. Adding the suffix by default makes that better: Firefox won't, for example, try rendering a PDF file as HTML.
tvdeyen
approved these changes
Oct 23, 2022
tvdeyen
added a commit
that referenced
this pull request
Nov 19, 2022
Always provide format with attachment URLs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this pull request for?
When linking to an attachment without the format, the browser does not necessarily know what to do with the file. Adding the suffix by default makes that better: Firefox won't, for example, try rendering a PDF file as HTML.
Checklist
addedchanged tests to cover this change