Use cache_key_with_version in page_etag #2365
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tvdeyen
force-pushed
the
fix-page-cache-etag
branch
from
7ebc166
to
a1aa227
Compare
The pages `cache_key` was including the `published_at` date before we changed it to just the `cache_version` (used by Rails to form the `cache_key`) Closes AlchemyCMS#2363
tvdeyen
force-pushed
the
fix-page-cache-etag
branch
from
a1aa227
to
45ec14f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this pull request for?
Fixes the
page_etagso that it includes thepublished_atdate form the page instead of just thepage#id.Closes #2363
Notable changes (remove if none)
The pages
cache_keywas including thepublished_atdate before wechanged it to just the
cache_version(used by Rails to form thecache_key)Screenshots
Remove if no visual changes have been made.
Checklist